Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logging: plumb 'Client._client_info' through to GAPIC API wrapper. #7901

Merged
merged 2 commits into from
May 8, 2019
Merged

Logging: plumb 'Client._client_info' through to GAPIC API wrapper. #7901

merged 2 commits into from
May 8, 2019

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented May 8, 2019

Toward #7825.

@tseaver tseaver added the api: logging Issues related to the Cloud Logging API. label May 8, 2019
@tseaver tseaver requested a review from tswast May 8, 2019 18:10
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 8, 2019
@tswast tswast mentioned this pull request May 8, 2019
Closed
14 tasks
@tseaver
Copy link
Contributor Author

tseaver commented May 8, 2019

The texttospeech failure is a Kokoro-internal glitch.

@tseaver
Copy link
Contributor Author

tseaver commented May 8, 2019

Logging systests were broken by a bug I introduced, and just fixed in 67dd4af.

@tseaver tseaver merged commit 87fd849 into googleapis:master May 8, 2019
@tseaver tseaver deleted the 7825-logging-client_info-gapic branch May 8, 2019 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tswast tswast tswast approved these changes

Assignees
No one assigned
Labels
api: logging Issues related to the Cloud Logging API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tseaver @tswast @googlebot