Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#744: Add E2E regression test for message publication + pull #795

Merged
merged 1 commit into from
Apr 6, 2015
Merged

#744: Add E2E regression test for message publication + pull #795

merged 1 commit into from
Apr 6, 2015

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Apr 3, 2015

Based on #794.

Publish one message to a topic and pull it via a subscription.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 3, 2015
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 749584e on tseaver:744-pubsub-pull_mode_e2e into fd06f16 on GoogleCloudPlatform:master.

@tseaver tseaver added the api: pubsub Issues related to the Pub/Sub API. label Apr 6, 2015
@tseaver
Copy link
Contributor Author

tseaver commented Apr 6, 2015

@dhermes I will rebase once #794 merges.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling a2e3312 on tseaver:744-pubsub-pull_mode_e2e into * on GoogleCloudPlatform:master*.

@tseaver
Copy link
Contributor Author

tseaver commented Apr 6, 2015

@dhermes PTAL. Note that this PR is an intermediate, on the way to returning Message instances (at the moment, the new test expects the raw mappings from the API).

@dhermes
Copy link
Contributor

dhermes commented Apr 6, 2015

LGTM

tseaver added a commit that referenced this pull request Apr 6, 2015
#744: Add E2E regression test for message publication + pull
@tseaver tseaver merged commit f3c3543 into googleapis:master Apr 6, 2015
@tseaver tseaver deleted the 744-pubsub-pull_mode_e2e branch April 6, 2015 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the Pub/Sub API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants