Bigtable: Add 'PartialRowsData.cancel'. #8176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
sduskis
suggested changes
May 28, 2019
|
@mf2199, I had some comments that need to be addressed regarding this PR. |
Appending unit-test to assert stop iteration of PartialRowsData() upon calling the cancel() method.
sduskis
approved these changes
Jun 14, 2019
tseaver
suggested changes
Jun 19, 2019
tseaver
approved these changes
Jun 19, 2019
tseaver
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
|
The |
tseaver
changed the title
crwilcox
reviewed
Jun 19, 2019
| @@ -376,6 +376,9 @@ def __init__(self, read_method, request, retry=DEFAULT_RETRY_READ_ROWS): | |||
| self.rows = {} | |||
| self._state = self.STATE_NEW_ROW | |||
|
|
|||
| # Flag to stop iteration, for any reason not related to self.retry() | |||
| self._stop = False | |||
There was a problem hiding this comment.
Looking over the code, it seems this is marking if the iterator has been cancelled. The comment and name of this sort of directed me to think maybe this did something different. would naming this self._cancelled be accurate?
tseaver
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
crwilcox
approved these changes
Jun 20, 2019
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7760.
Introducing a "stop" flag into the iterable PartialRowsData() class. Setting this flag to True results in cancelling of the iteration the next time the iterator is called.