Monitoring: Fix environment variables for VPC tests.

[busunkim96]

Follow up to #8295.

CC @steinwaywhw

[steinwaywhw]

Hi @busunkim96 sorry I miscommunicated in our last thread. Could you keep the environment variable names as is without changing them? I believe the VPC team sets "PROJECT_ID" when they run the tests.

[steinwaywhw]

I think @bmccutchon knows better about what environment variables the VPCSC team needs.

[busunkim96]

I changed it as we also use PROJECT_ID as our default system test project. I'll poke around a bit more to see what the best way to sort this out is. Thanks for the heads up!

[bmccutchon]

Yes, we do set PROJECT_ID in VPCSC tests.

[tseaver]

Both Container Analysis and Grafeas jobs failed with "Test Fusion Url (This url will not work until build finishes)". I have tagged Kokoro to re-run the tests.

[tseaver]

ISTM that the whole TestVPCServiceControl testcase class is conditional on the environment variables being set. Would we be better off moving the pytest.mark.skipif stuff to decorate the class, rather than the individual methods?

[bmccutchon]

We (VPCSC) would actually prefer it if as many of these tests as possible are not skipped on your CI so that we can more easily tell whether a failure is VPCSC-related. (If it's also failing on your CI, it's almost certainly not a VPCSC error.)

[busunkim96]

@bmccutchon That sounds good. This also came up for the Asset VPC tests. I'll work on resolving the environment variable/test runs today.

[busunkim96]

@bmccutchon I'm still having a bit of trouble rationalizing the CI setup. Could you look over this and make sure I have the correct understanding?

PROJECT_ID - a project inside the VPCSC perimeter
GOOGLE_CLOUD_TESTS_VPCSC_OUTSIDE_PERIMETER_PROJECT - a project outside the VPCSC perimeter
GOOGLE_CLOUD_TESTS_IN_VPCSC - "true" in the VPCSC testing environment

Once this is correct I'll make another PR to fix the other VPCSC tests.

Thanks!

[bmccutchon]

Your understanding is correct.

[plamut]

The resolution of my comment is good, approving that. 👍

Cannot say much about the rest, not familiar enough with it, I'll leave that to others.