Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BigQuery Snippets: Use autodetected location #8341

Merged
merged 3 commits into from
Jun 18, 2019

Conversation

grant
Copy link
Contributor

@grant grant commented Jun 14, 2019

Remove location as it is now autodetected.
See bug b/116968956 .

Remove location as it is now autodetected. See bug b/116968956 .
@grant grant requested a review from a team June 14, 2019 18:47
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 14, 2019
@busunkim96 busunkim96 added the api: bigquery Issues related to the BigQuery API. label Jun 14, 2019
@busunkim96
Copy link
Contributor

Container Analysis and Grafeas are failing because those libraries have not yet been merged.

@grant
Copy link
Contributor Author

grant commented Jun 14, 2019

I don't know why the tests are failing.
It is hard finding the error with this build setup.

After a few clicks, I think there's a stacktrace with an unrelated error:

[11:54:04][ERROR] Failed to get build config
com.google.devtools.kokoro.config.ConfigException: Couldn't find build configuration under /tmp/workspace/workspace/cloud-devrel/client-libraries/google-cloud-python/presubmit/containeranalysis/src/github/google-cloud-python/.kokoro/presubmit.

@busunkim96
Copy link
Contributor

@grant Yep, ContainerAnalysis and Grafeas are pending in #8186 (they're failing since Kokoro configs have already been merged internally). You can ignore those test failures.

@grant
Copy link
Contributor Author

grant commented Jun 15, 2019

How can we ignore the test failures if the tests are failing? Are we implying that we want to approve this PR before all checks are green?

@busunkim96
Copy link
Contributor

Yes, as long as the tests for the relevant APIs are passing we can merge it. We realize that's not ideal, but it's our current process.

@grant
Copy link
Contributor Author

grant commented Jun 18, 2019

@busunkim96 OK.
So BQ passes.
Merge?

@busunkim96 busunkim96 merged commit 7dc367e into googleapis:master Jun 18, 2019
@grant grant deleted the patch-2 branch June 18, 2019 19:50
@alixhami
Copy link
Contributor

Important to note that nobody actually approved this PR.

@busunkim96
Copy link
Contributor

@alixhami Sorry, that is my bad 🤦‍♀️. I assumed it had been reviewed.

We're putting splitting this repo on the OKRs for the next quarter and will turn on stricter protections (required status checks, reviews, etc) at that point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants