-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BigQuery Snippets: Use autodetected location #8341
Conversation
Remove location as it is now autodetected. See bug b/116968956 .
Container Analysis and Grafeas are failing because those libraries have not yet been merged. |
I don't know why the tests are failing. After a few clicks, I think there's a stacktrace with an unrelated error:
|
How can we ignore the test failures if the tests are failing? Are we implying that we want to approve this PR before all checks are green? |
Yes, as long as the tests for the relevant APIs are passing we can merge it. We realize that's not ideal, but it's our current process. |
@busunkim96 OK. |
Important to note that nobody actually approved this PR. |
@alixhami Sorry, that is my bad 🤦♀️. I assumed it had been reviewed. We're putting splitting this repo on the OKRs for the next quarter and will turn on stricter protections (required status checks, reviews, etc) at that point. |
Remove location as it is now autodetected.
See bug b/116968956 .