Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Storage: Avoid escaping tilde in blob public / signed URLs. #8434

Merged
merged 2 commits into from
Jun 20, 2019
Merged

Storage: Avoid escaping tilde in blob public / signed URLs. #8434

merged 2 commits into from
Jun 20, 2019

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Jun 19, 2019

Supersedes #8200.

@tseaver tseaver added the api: storage Issues related to the Cloud Storage API. label Jun 19, 2019
@tseaver tseaver requested a review from crwilcox June 19, 2019 20:58
@tseaver tseaver requested a review from frankyn as a code owner June 19, 2019 20:58
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 19, 2019
@tseaver tseaver mentioned this pull request Jun 19, 2019
Closed
frankyn
frankyn suggested changes Jun 19, 2019
View reviewed changes
Copy link
Member

@frankyn frankyn left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tseaver, added a two questions.

storage/google/cloud/storage/blob.py Show resolved Hide resolved
storage/google/cloud/storage/blob.py Outdated Show resolved Hide resolved
@tseaver tseaver merged commit ccac1e1 into googleapis:master Jun 20, 2019
@tseaver tseaver deleted the 8200-storage-avoid-quoting-tildes branch June 20, 2019 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frankyn frankyn frankyn approved these changes

@crwilcox crwilcox Awaiting requested review from crwilcox

Assignees
No one assigned
Labels
api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tseaver @frankyn @googlebot