Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Firestore - fixed - unique key to every collection and document #8497

Closed
wants to merge 1 commit into from
Closed

Firestore - fixed - unique key to every collection and document #8497

wants to merge 1 commit into from

Conversation

pchauhan-qlogic
Copy link
Contributor

Fixes #7829 #8090 #7130

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 28, 2019
@AVaksman AVaksman added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 4, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 4, 2019
tseaver
tseaver suggested changes Jul 8, 2019
View reviewed changes
Copy link
Contributor

@tseaver tseaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs blackening.

@tseaver tseaver mentioned this pull request Jul 10, 2019
Merged
@tseaver
Copy link
Contributor

tseaver commented Jul 10, 2019

#8637 contains a better take on using a unique key for each top-level collection.

#8638 does a cleaner take on the unsubscribe cleanup handling.

@tseaver tseaver closed this Jul 10, 2019
tseaver added a commit that referenced this pull request Jul 10, 2019
@tseaver
Firestore: Improve cleanups for 'watch' system tests. (#8638)
8bb6ef0 
H/t to @pchauhan-qlogic for identifying the need to unsubscribe.

Also, use unique collection IDs for 'watch' tests.

Exception for 'test_watch_query_order', which requires that we use the
special 'users' collection, in order to take advantage of its index.

Supersedes #8497.

Closes #6605, #7130.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tseaver tseaver tseaver requested changes

@crwilcox crwilcox Awaiting requested review from crwilcox

@frankyn frankyn Awaiting requested review from frankyn

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Firestore: 'test_collection_add' flakes
5 participants
@pchauhan-qlogic @tseaver @googlebot @AVaksman @yoshi-kokoro