-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Firestore : add emulator support #8542
Firestore : add emulator support #8542
Conversation
Have we validated our tests pass against the emulator? |
c66b715
to
746a6fa
Compare
The Doc testing requires modifications to be made to |
The failed system test is due to #7130. @HemangChothani To fix the docs build, you could update for local_dep in LOCAL_DEPS:
session.install("-e", local_dep |
7da4fa9
to
868d77b
Compare
85eeb64
to
1b80ea2
Compare
I don't see a response to the question @crwilcox asked:
|
@HemangChothani I am closing this because I ended up implementing this PR #8721 and forgot you had started on this. There are 4 open bugs internally against the emulator for small differences I found when running the tests against the emulator |
Fixes: #7500