Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firestore : add emulator support #8542

Conversation

HemangChothani
Copy link
Contributor

Fixes: #7500

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 1, 2019
@crwilcox
Copy link
Contributor

crwilcox commented Jul 1, 2019

Have we validated our tests pass against the emulator?

@AVaksman AVaksman added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 4, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 5, 2019
@tseaver tseaver added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 8, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 8, 2019
@tseaver tseaver added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 9, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 9, 2019
@HemangChothani
Copy link
Contributor Author

The Doc testing requires modifications to be made to environment_vars.py file found in the Core library; namely extending the emulator variable declarations by another variable. During the test, however, the core library gets overwritten through pip install, losing the changes made to environment_vars.py and hence the newly added variable, which results in the doc test failure.

@tseaver
Copy link
Contributor

tseaver commented Jul 10, 2019

The failed system test is due to #7130.

@HemangChothani To fix the docs build, you could update firestore/noxfile.py to install the "local dependencies", inside the docs session, e.g.:

    for local_dep in LOCAL_DEPS:
        session.install("-e", local_dep

@tseaver tseaver added api: firestore Issues related to the Firestore API. kokoro:force-run Add this label to force Kokoro to re-run the tests. testing labels Jul 12, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 12, 2019
@tseaver
Copy link
Contributor

tseaver commented Jul 12, 2019

@HemangChothani

I don't see a response to the question @crwilcox asked:

Have we validated our tests pass against the emulator?

@crwilcox
Copy link
Contributor

@HemangChothani I am closing this because I ended up implementing this PR #8721 and forgot you had started on this. There are 4 open bugs internally against the emulator for small differences I found when running the tests against the emulator

@crwilcox crwilcox closed this Jul 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: firestore Issues related to the Firestore API. cla: yes This human has signed the Contributor License Agreement. testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Firestore: add emulator support
6 participants