Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Connection factories for credentials. #864

Merged
merged 1 commit into from
May 14, 2015
Merged

Adding Connection factories for credentials. #864

merged 1 commit into from
May 14, 2015

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented May 8, 2015

This allows us to load a Connection and a set of credentials simultaneously.

NOTE: Has #840 as diffbase.

@dhermes dhermes added the api: storage Issues related to the Cloud Storage API. label May 8, 2015
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 8, 2015
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling c37ca9a on dhermes:connection-factories into a9bc7fe on GoogleCloudPlatform:master.

This was referenced May 13, 2015
Merged
Closed
@dhermes
Adding Connection factories for credentials.
d953994 
This allows us to load a Connection and a set of credentials
simultaneously.
@dhermes dhermes force-pushed the connection-factories branch from c37ca9a to d953994 Compare May 14, 2015 18:48
@dhermes
Copy link
Contributor Author

dhermes commented May 14, 2015

@tseaver Rebased after #840 was merged. PTAL.

@tseaver
Copy link
Contributor

tseaver commented May 14, 2015

LGTM

dhermes added a commit that referenced this pull request May 14, 2015
@dhermes
Merge pull request #864 from dhermes/connection-factories
9c4867a 
Adding Connection factories for credentials.
@dhermes dhermes merged commit 9c4867a into googleapis:master May 14, 2015
@dhermes dhermes deleted the connection-factories branch May 14, 2015 20:26
@dhermes dhermes mentioned this pull request Jun 4, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dhermes @coveralls @tseaver @googlebot