BigQuery Storage: Add support for arrow format in BQ Read API #8644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
tswast
added
the
api: bigquerystorage
shollyman
approved these changes
Jul 11, 2019
|
|
||
| _AVRO_BYTES_OPERATION = "parse ReadRowResponse messages with Avro bytes" | ||
| _ARROW_BYTES_OPERATION = "parse ReadRowResponse messages with Arrow bytes" | ||
| _FASTAVRO_REQUIRED = "fastavro is required to {operation}." |
There was a problem hiding this comment.
I assume these parameterized errors are for when you do things like to_arrow with avro bytes?
There was a problem hiding this comment.
Yeah, this is vestigial from when I was planning to implement to_arrow for Avro streams. Removed for now.
|
|
||
| Args: | ||
| read_session (google.cloud.bigquery_storage_v1beta1.types.ReadSession): | ||
| A read session. This is required because it contains the schema | ||
| used in the stream messages. | ||
| """ | ||
| if fastavro is None: | ||
| raise ImportError(_FASTAVRO_REQUIRED) |
There was a problem hiding this comment.
does this need to be parameterized as well?
There was a problem hiding this comment.
Removed the {operation} from error message since I didn't actually need it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_StreamParserabstract, and breaks it into two implementations: one for arrow and one for avro. The implementation is selected is based on the schema set in the ReadSession.to_arrowto reader classes.Split out from #8551 so that the changes to
google-cloud-bigquery-storagecan be submitted and released separately from the changes togoogle-cloud-bigquery.