Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BigQuery: Add 'max_results' param to 'QueryJob.result()'. #9167

Merged
merged 2 commits into from
Sep 4, 2019
Merged

BigQuery: Add 'max_results' param to 'QueryJob.result()'. #9167

merged 2 commits into from
Sep 4, 2019

Conversation

shubha-rajan
Copy link
Contributor

First of 3 PRs towards resolving #9105 as described in review for #9147

@shubha-rajan shubha-rajan requested a review from a team September 3, 2019 21:06
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 3, 2019
tswast
tswast reviewed Sep 3, 2019
View reviewed changes
Copy link
Contributor

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know it's a bit silly to do so, but let's add a unit test to the test_job.py module to make sure max_results works as expected.

@tseaver tseaver added the api: bigquery Issues related to the BigQuery API. label Sep 3, 2019
@tseaver tseaver changed the title BigQuery: added max_results param to QueryJob.result() BigQuery: Add 'max_results' param to 'QueryJob.result()'. Sep 3, 2019
tswast
tswast approved these changes Sep 4, 2019
View reviewed changes
Copy link
Contributor

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@tswast tswast merged commit 27e7abd into googleapis:master Sep 4, 2019
@tswast tswast mentioned this pull request Sep 4, 2019
Merged
emar-kar pushed a commit to MaxxleLLC/google-cloud-python that referenced this pull request Sep 11, 2019
@shubha-rajan @emar-kar
Add max_results parameter to QueryJob.result(). (googleapis#9167)
1d17c06 
* added max_results param to QueryJob.result()

* added test to check that max_results param appears in tabledata.list call arguments
emar-kar pushed a commit to MaxxleLLC/google-cloud-python that referenced this pull request Sep 18, 2019
@shubha-rajan @emar-kar
Add max_results parameter to QueryJob.result(). (googleapis#9167)
e4fe8b7 
* added max_results param to QueryJob.result()

* added test to check that max_results param appears in tabledata.list call arguments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tswast tswast tswast approved these changes

Assignees
No one assigned
Labels
api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shubha-rajan @tswast @tseaver @googlebot