-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pubsub): add stop method #9365
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
No problem, pushed |
@pradn, thanks for leading me through |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, including the locking (the code is also easier to reason about with the _batch_lock
spanning across the entire bodies of the publish/stop methods).
Suggested two small improvements, if it's not too late (had to prioritize other stuff, apologies).
Edit: To clarify, this PR can be merged as-is if it's blocking other @pradn's work, and the suggested changes, if accepted, can be added separately.
Works for me, thanks! |
Co-Authored-By: Peter Lamut <plamut@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for the quick changes!
Add
stop()
method, which sends all outstanding messages and waits until all futures resolved. Similar features in Go and Java.Closes #4913
Closes #6883