Fixes #937 - Adds HTTP method and URL to exceptions. #938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
| @@ -391,7 +391,8 @@ def api_request(self, method, path, query_params=None, | |||
| target_object=_target_object) | |||
|
|
|||
| if not 200 <= response.status < 300: | |||
| raise make_exception(response, content) | |||
| raise make_exception(response, content, | |||
| request_string=method+' '+url) | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Let's not let this thing linger. Merge or close. |
This was referenced Jun 25, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example:
Old:
gcloud.exceptions.NotFound: 404 Resource not found (resource=new).New:
gcloud.exceptions.NotFound: 404 Resource not found (resource=new). (DELETE https://pubsub.googleapis.com/v1beta2/projects/jjg-cloud-research/topics/new)Wasn't sure about a couple things, so wanted to ask...
request_string). Seems expressive, but would rather pass a request object or something similar. Should I rename? Or pass two (methodandurl) on tomake_exception?make_exceptioncall (seemed like it might be better done on a separate line?)