Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bigquery): add script statistics to job resource #9428

Merged
merged 2 commits into from
Oct 10, 2019

Conversation

tswast
Copy link
Contributor

@tswast tswast commented Oct 8, 2019

In addition to the parent ID property, the new scripting feature adds a new scriptStatistics property. This can be calling jobs.get on a script child job in the APIs Explorer.

  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Follow-up to #9190 🦕

@tswast tswast added the api: bigquery Issues related to the BigQuery API. label Oct 8, 2019
@tswast tswast requested review from shollyman and a team October 8, 2019 20:26
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 8, 2019
@tswast tswast changed the title feat(bigquery): Add script statistics to job resource. feat(bigquery): add script statistics to job resource Oct 8, 2019
Copy link
Contributor

@tseaver tseaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add explicit unit test coverage for the ScriptStackFrame and ScriptStatistics classes.

@tswast tswast requested a review from tseaver October 9, 2019 20:02
Copy link
Contributor

@shollyman shollyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Iterating by parent was already implemented, as were the ParentJobId and NumChildJobs fields on JobStatistics. This rounds out the implementation. I am assuming integration testing will happen in the context of samples.

@tswast tswast merged commit 1d4a547 into googleapis:master Oct 10, 2019
@tswast tswast deleted the bq-script-stats branch December 27, 2019 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants