feat(bigquery): add Dataset.default_partition_expiration_ms and Table.require_partition_filter properties #9464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…require_partition_filter properties Samples double as system tests. I aim to use them here: * https://cloud.google.com/bigquery/docs/managing-partitioned-tables#require-filter * https://cloud.google.com/bigquery/docs/updating-datasets#partition-expiration Note: this also (silently) deprecates TimePartitioning.require_partition_filter, as that's duplicating the same functionality. I was curious why the expiration_ms wasn't also moving up, but then I realized that property only makes sense if a partition is assocatied with a timestamp.
googlebot
added
the
cla: yes
tswast
changed the title
shollyman
approved these changes
Oct 15, 2019
| If set to true, queries over the partitioned table require a | ||
| partition filter that can be used for partition elimination to be | ||
| specified. | ||
| DEPRECATED: Use |
There was a problem hiding this comment.
Are there any annotations we can/should add to help docs/and existing consumers to understand this is no longer the preferred mechanism?
There was a problem hiding this comment.
👍 Added deprecation warning message in 84e2c3c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Samples double as system tests. I aim to use them here:
Note: this also (silently) deprecates
TimePartitioning.require_partition_filter, as that's duplicating the
same functionality.
I was curious why the expiration_ms wasn't also moving up, but then I
realized that property only makes sense if a partition is assocatied
with a timestamp.