Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc(bigquery): add table create sample using integer range partitioning #9478

Merged
merged 4 commits into from
Nov 6, 2019
Merged

doc(bigquery): add table create sample using integer range partitioning #9478

merged 4 commits into from
Nov 6, 2019

Conversation

tswast
Copy link
Contributor

@tswast tswast commented Oct 15, 2019 •
edited
Loading

This code sample doubles as a system test for integer range partitioning features. Follow-up to #9477

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 15, 2019
@tswast tswast mentioned this pull request Oct 15, 2019
Merged
@tswast
doc(bigquery): add table create sample using integer range partitioning
e1f6921 
This code sample doubles as a system test for integer range partitioning
features.
@tswast tswast force-pushed the bq-range-partitioning-samples branch from 846b60c to e1f6921 Compare October 18, 2019 16:47
@tswast tswast changed the title doc(bigquery): add code samples for integer range partitioning doc(bigquery): add table create sample using integer range partitioning Oct 18, 2019
@tswast tswast marked this pull request as ready for review October 18, 2019 16:47
@tswast tswast requested review from a team and shollyman October 18, 2019 16:47
@plamut plamut added type: docs Improvement to the documentation for an API. api: bigquery Issues related to the BigQuery API. labels Oct 22, 2019
plamut
plamut reviewed Oct 22, 2019
View reviewed changes
Copy link
Contributor

@plamut plamut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, please just blacken the changes (the lint check fails).

I noticed that table range partitioning info is not presented anywhere in the GCP control panel, but that's not a client library issue.

@tswast tswast requested a review from plamut October 24, 2019 22:44
plamut
plamut reviewed Oct 25, 2019
View reviewed changes
Copy link
Contributor

@plamut plamut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed offline - even if not necessary, it is a good idea to include the sample in the Sphinx docs, too.

@tswast tswast requested a review from plamut October 25, 2019 22:38
@plamut
Copy link
Contributor

plamut commented Nov 4, 2019 •
edited
Loading

@shollyman Is there anything that you might want to add here before merging?

Thanks!

Update: Seems like no, merging then. :)

@plamut plamut merged commit c4a69d4 into googleapis:master Nov 6, 2019
@tswast tswast deleted the bq-range-partitioning-samples branch December 27, 2019 21:27
@yoshi-automation yoshi-automation mentioned this pull request Jan 29, 2020
Merged
@plamut plamut mentioned this pull request Feb 7, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plamut plamut plamut approved these changes

@shollyman shollyman Awaiting requested review from shollyman

Assignees
No one assigned
Labels
api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement. type: docs Improvement to the documentation for an API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tswast @plamut @googlebot