Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(bigquery): add TypeError if wrong job_config type is passed to client job methods #9506

Merged
merged 3 commits into from
Oct 23, 2019
Merged

feat(bigquery): add TypeError if wrong job_config type is passed to client job methods #9506

merged 3 commits into from
Oct 23, 2019

Conversation

HemangChothani
Copy link
Contributor

Fixes #9480

@HemangChothani HemangChothani requested review from tswast, plamut and a team October 21, 2019 09:20
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 21, 2019
plamut
plamut suggested changes Oct 21, 2019
View reviewed changes
Copy link
Contributor

@plamut plamut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a useful addition, thanks!

I made a few improvement suggestions, mostly related to code duplication and covering more probable real world errors in tests.

bigquery/google/cloud/bigquery/client.py Outdated Show resolved Hide resolved
bigquery/google/cloud/bigquery/client.py Outdated Show resolved Hide resolved
bigquery/tests/unit/test_client.py Outdated Show resolved Hide resolved
plamut
plamut approved these changes Oct 22, 2019
View reviewed changes
Copy link
Contributor

@plamut plamut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now 👍

tswast
tswast approved these changes Oct 22, 2019
View reviewed changes
Copy link
Contributor

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@plamut plamut changed the title feat(bigquery): add ValueError if wrong job_config type is passed to client job methods feat(bigquery): add TypeError if wrong job_config type is passed to client job methods Oct 23, 2019
@plamut plamut merged commit 4098386 into googleapis:master Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tswast tswast tswast approved these changes

@plamut plamut plamut approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
4 participants
@HemangChothani @tswast @plamut @googlebot