-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(pubsub): update batching and flow control parameters to be same as the other client libraries #9597
Conversation
@busunkim96 This PR is part of an effort to standardize our client library default settings. We're looking at two changes. One change increases how often we publish bundles of messages (which shouldn't be a breaking change). The other has to do with flow control (how many messages we can hold and how long we hold onto messages before releasing them to be redelivered). I'm more worried about this change negatively affecting users who aren't setting their own defaults. What do you recommend here? |
pubsub/tests/unit/pubsub_v1/subscriber/test_streaming_pull_manager.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good per se. I am not totally familiar with the defaults in other libraries, thus I'll leave that aspect to others to verify.
Merging to unblock a related PR. If it turns out that additional changes are needed, we can make them in a follow-up PR. |
Changes: