tests(dlp): normalize VPCSC configuration in systests #9608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tseaver
added
testing
api: dlp
googlebot
added
the
cla: yes
10 tasks
busunkim96
approved these changes
Nov 5, 2019
- Move 'skip_unless_inside_vpcsc' to class scope. - Drop 'skip_unless_outside_project': it is guaranteed to be set when running tests inside VPCSC. - Drop never-reached branch for outside in '_do_test'. - Don't swallow unexpected exceptions inside '_is_rejected.
tseaver
added
the
do not merge
|
I tagged with "do not merge" because I believe we should refactor all these un-idiomatic tests along the lines of the changes in #9618. |
|
@busunkim96 I removed the "do not merge" label after updating the tests to follow the pattern in #9618. |
tseaver
removed
the
do not merge
parthea
pushed a commit
that referenced
this pull request
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Toward #9580