Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vision): update a couple expected messages to fix broken vision vpc sc tests #9640

Closed
wants to merge 1 commit into from

Conversation

brendanlundy
Copy link
Contributor

@brendanlundy brendanlundy commented Nov 8, 2019

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 8, 2019
@brendanlundy brendanlundy changed the title Vision: Update a couple expected messages to fix broken vision VPC SC tests fix(vision) update a couple expected messages to fix broken vision VPC SC tests Nov 8, 2019
@emar-kar emar-kar changed the title fix(vision) update a couple expected messages to fix broken vision VPC SC tests fix(vision): update a couple expected messages to fix broken vision VPC SC tests Nov 8, 2019
@emar-kar emar-kar changed the title fix(vision): update a couple expected messages to fix broken vision VPC SC tests fix(vision): update a couple expected messages to fix broken vision vpc sc tests Nov 8, 2019
@emar-kar
Copy link
Contributor

emar-kar commented Nov 8, 2019

Change your commit message as it is shown in the title now, please. See conventionalcommits.org details.

@brendanlundy
Copy link
Contributor Author

Updated commit message.

@busunkim96
Copy link
Contributor

@brendanlundy I believe this will be resolved in #9620

@brendanlundy
Copy link
Contributor Author

@brendanlundy I believe this will be resolved in #9620

Yes, #9620 will fix it. We don't need my change.

@busunkim96
Copy link
Contributor

Closing as #9620 has been merged.

@busunkim96 busunkim96 closed this Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants