Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(bigquery): fix undelete table system test to use milliseconds in snapshot decorator #9649

Merged
merged 1 commit into from
Nov 9, 2019

Conversation

tswast
Copy link
Contributor

@tswast tswast commented Nov 8, 2019

This fixes a flakey system test, where sometimes we sent an invalid
timestamp as a snapshot to copy from.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #9633

…n snapshot decorator

This fixes a flakey system test, where sometimes we sent an invalid
timestamp as a snapshot to copy from.
@tswast tswast requested a review from a team November 8, 2019 23:39
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BigQuery: 'test_undelete_table' fails with 500
3 participants