Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start DX docs for bigquery: client authorization / configuration. #985

Merged
merged 4 commits into from
Jul 20, 2015
Merged

Start DX docs for bigquery: client authorization / configuration. #985

merged 4 commits into from
Jul 20, 2015

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Jul 13, 2015

No description provided.

@tseaver tseaver added the api: bigquery Issues related to the BigQuery API. label Jul 13, 2015
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 13, 2015
@tseaver tseaver mentioned this pull request Jul 13, 2015
Merged
dhermes
dhermes reviewed Jul 14, 2015
View reviewed changes
docs/bigquery-usage.rst
-----------------------------

- Use :class:`Client <gcloud.bigquery.client.Client>` objects to configure
your applications.

This comment was marked as spam.

Sign in to view

@dhermes
Copy link
Contributor

dhermes commented Jul 14, 2015

Shouldn't you also update docs/_static/js/main.js to allow a BigQuery heading?

@tseaver
Copy link
Contributor Author

tseaver commented Jul 20, 2015

I missed the apiQsSection bit because I was greping for pubsub (which isn't there either), and the other case uses 'Pub/Sub' in its search. 2930b1f updates both (but doesn't actually add the "in 10 seconds" bits for pubsub / bigquery).

dhermes
dhermes reviewed Jul 20, 2015
View reviewed changes
docs/_static/js/main.js
if (itemName !== 'Datastore' &&
itemName !== 'Storage' &&
itemName !== 'Pub/Sub' &&
itemName !== 'Big Query') {

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@dhermes
Copy link
Contributor

dhermes commented Jul 20, 2015

Everything looks fine expect for s/Big Query/BigQuery. Do you have a plan in place for actually introducing the code? I don't want to have the doc committed for too long without any corresponding code.

@tseaver
Copy link
Contributor Author

tseaver commented Jul 20, 2015

I mean to flesh out the "usage" doc first, in order to ask for review from the back-end team (similar to the process for pubsub). @jgeewax would you rather see code commits interleaved?

tseaver added a commit that referenced this pull request Jul 20, 2015
@tseaver
Merge pull request #985 from tseaver/bigquery-devx-client_authz_confi…
40e694d 
…gure

Start DX docs for bigquery:  client authorization / configuration.
@tseaver tseaver merged commit 40e694d into googleapis:master Jul 20, 2015
@jgeewax
Copy link
Contributor

jgeewax commented Jul 20, 2015

@tseaver : No preference from me... I suspect that the BQ team would look at usage docs first and give feedback, but I don't think it's a showstopper if things are interleaved.

@tseaver tseaver deleted the bigquery-devx-client_authz_configure branch July 20, 2015 22:43
@dhermes dhermes mentioned this pull request Jul 21, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tseaver @dhermes @jgeewax @googlebot