Remove implicit environ from storage #988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
tseaver
referenced
this pull request
in dhermes/google-cloud-python
Jul 14, 2015
dhermes
referenced
this pull request
in dhermes/google-cloud-python
Jul 14, 2015
Towards removing storage._implicit_environ.
dhermes
force-pushed
the
remove-storage-implicit-environ
branch
from
e627eaa
to
cc7af4e
Compare
| mock_defaults = _DefaultsContainer(*args, **kwargs) | ||
| return _Monkey(_helpers, _DEFAULTS=mock_defaults) | ||
|
|
||
|
|
||
| def _setup_defaults(test_case, *args, **kwargs): | ||
| test_case._replaced_defaults = _helpers._DEFAULTS | ||
| _helpers._DEFAULTS = _DefaultsContainer(*args, **kwargs) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
LGTM |
dhermes
added a commit
that referenced
this pull request
Jul 20, 2015
Remove implicit environ from storage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Has #987 as diffbase.
@tseaver The 2nd commit in this PR is all over the place. I can try to re-work if it seems too daunting.
It started out as just deleting
_implicit_environand then dealing with all the dependencies. This includedgcloud.get_default_project()_client_or_connectionfor_require_client(and movingBucket._require_clientto_PropertyMixin)connection(from_client_or_connection) to beclient.connectionclientproperties toACLand_PropertyMixinmethodsstorage._require_connectionmethodbucketrequired inBlobconstructorBucket.createso that both the project and connection come from theclient