-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api_core): add retry param into PollingFuture() and it's inheritors #9923
Conversation
# If the currently cached operation is done, no need to make another | ||
# RPC as it will not change once done. | ||
if not self._operation.done: | ||
self._operation = self._refresh() | ||
self._operation = self._refresh(retry=retry) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding retry
into inheritor of the PollingFuture()
(the one above) and passing it further. As self._refresh
is functools.partial
, we can just pass retry
as a named arg - it'll be added to those args which were prepared while creating functools.partial
Some BigQuery tests failed, but, as I see, they are failing in pure
|
This reverts commit 13b8553.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. Thanks for your patience in the review.
I'd like an API core owner to sign off as well, such as @busunkim96
Towards #6197
Looks like it's the last thing that should be done for this issue. CMIIW.