Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documenting exclusion of GCE for generate_signed_url. #993

Merged
merged 1 commit into from
Jul 20, 2015
Merged

Documenting exclusion of GCE for generate_signed_url. #993

merged 1 commit into from
Jul 20, 2015

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented Jul 14, 2015

Fixes #983.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 14, 2015
@tseaver
Copy link
Contributor

tseaver commented Jul 20, 2015

LGTM

dhermes added a commit that referenced this pull request Jul 20, 2015
@dhermes
Merge pull request #993 from dhermes/fix-983
c11d9b5 
Documenting exclusion of GCE for generate_signed_url.
@dhermes dhermes merged commit c11d9b5 into googleapis:master Jul 20, 2015
@dhermes dhermes deleted the fix-983 branch July 20, 2015 19:21
@tseaver
Copy link
Contributor

tseaver commented Jul 20, 2015

Oops, broke tox -e docs:

Warning, treated as error:

/home/travis/build/GoogleCloudPlatform/gcloud-python/gcloud/storage/blob.py:docstring of gcloud.storage.blob.Blob.generate_signed_url:6: ERROR: Unexpected indentation.

ERROR: InvocationError: '/home/travis/build/GoogleCloudPlatform/gcloud-python/.tox/docs/bin/sphinx-build -W -b html -d docs/_build/doctrees docs docs/_build/html'

@tseaver tseaver mentioned this pull request Jul 20, 2015
Merged
@dhermes
Copy link
Contributor Author

dhermes commented Jul 20, 2015

I feel like I fixed this locally; must have forgotten to git add the final fixes.

@dhermes dhermes mentioned this pull request Jul 21, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: core cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dhermes @tseaver @googlebot