feat(datacatalog): add quickstart sample for creating fileset entry. #9977
Conversation
googlebot
added
the
cla: yes
mesmacosta
changed the title
| # TODO(developer): Set entry_id to the ID of the entry to create. | ||
| # entry_id = "your_entry_id" | ||
|
|
||
| # 1. Environment cleanup: delete pre-existing data. |
There was a problem hiding this comment.
Are developers expected to encounter pre-existing data? This step seems like something that'd be better suited for a test setup.
There was a problem hiding this comment.
First time developers run no, the intention is to show a reproducible scenario, every time developers run it, it will work, and it shows how to delete the entries in case they need it.
WDYT? An option would be to split this part into a cleanup tutorial.
There was a problem hiding this comment.
A quickstart sample should introduce as few concepts as possible. I recommend splitting this out.
There was a problem hiding this comment.
sure, will send a separate PR for a clean up tutorial
There was a problem hiding this comment.
The cleanup logic has been removed from this PR.
| @@ -0,0 +1,40 @@ | |||
| # Copyright 2019 Google LLC | |||
There was a problem hiding this comment.
Let's put this in a tests/quickstart/ folder to reflect the sample location. You might need a tests/quickstart/__init__.py file as well.
tswast
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
Fixes #9976