Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(automl): fix TablesClient.predict for array and struct #9991

Merged
merged 2 commits into from
Jan 28, 2020
Merged

fix(automl): fix TablesClient.predict for array and struct #9991

merged 2 commits into from
Jan 28, 2020

Commits on Dec 18, 2019

  1. fix(automl): fix TablesClient.predict for list and struct 

    The Predict request payload is proto. Previously Python dict is
automatically converted to proto. However, the conversion failed for
google.protobuf.ListValue and google.protobuf.Struct. Changing the
structure of the Python dict might fix the problem. However, this PR
fixes the problem by generating the proto message directly. So there
is no auto conversion step.

FIXES googleapis#9887
    Helin Wang committed Dec 18, 2019
    Configuration menu
    Copy the full SHA
    66302e5 View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2020

  1. Address comment: remove protobuf dependency requirement. 

    protobuf is already a transitive dependency (see google-api-core's
setup.py)
    Helin Wang committed Jan 27, 2020
    Configuration menu
    Copy the full SHA
    20209f6 View commit details
    Browse the repository at this point in the history