Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple authentication when running in GAE + GCE (or locally via Cloud SDK) #102

Closed
jgeewax opened this issue Mar 2, 2015 · 6 comments · Fixed by #105
Closed

Simple authentication when running in GAE + GCE (or locally via Cloud SDK) #102

jgeewax opened this issue Mar 2, 2015 · 6 comments · Fixed by #105
Assignees
Labels
auth 🚨 This issue needs some love. triage me I really want to be triaged.

Comments

@jgeewax
Copy link

jgeewax commented Mar 2, 2015

Ideally we can "figure out" the environment and "just use the right credentials".

Order of eval should be the same as Python:

  1. Specific credentials provided in code
  2. Specific credentials provided in env var
  3. Credential available in the Cloud SDK's magic path
  4. GAE credentials (magically discovered)
  5. GCE credentials (magically discovered)
@blowmage
Copy link
Contributor

@jgeewax We already support 1 and 2, and I have code for 3. It looks to me that the "magically discovered" credentials will be supported in google-auth-library-ruby. I think it would make more sense to wait for google-auth-library-ruby to be available than to duplicate that code here. What do you think?

@blowmage
Copy link
Contributor

I just saw that google-api-client and googleauth were updated this morning. I'll update our dependency on those libraries and rework my changes use them instead.

@jgeewax
Copy link
Author

jgeewax commented Mar 24, 2015

We can't announce anything until we have all these things done, so it's up to you whether you want to wait for external feedback or duplicate code. I'm fine with waiting, but we should set a hard deadline where we decide to stop waiting........

@blowmage
Copy link
Contributor

The code that would be duplicated was released this morning. My original comment was written last week but wasn't submitted until this morning.

@jgeewax
Copy link
Author

jgeewax commented Mar 24, 2015 via email

@blowmage
Copy link
Contributor

Google App Engine doesn't have a Ruby runtime so that will be skipped for now. Updating description.

blowmage added a commit that referenced this issue Mar 24, 2015
Add support for the Cloud SDK's credential application file as well as Google Compute Engine.

[Closes #102]
@blowmage blowmage modified the milestones: Core Stable, 0.1.0 Aug 24, 2015
@yoshi-automation yoshi-automation added triage me I really want to be triaged. 🚨 This issue needs some love. labels Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auth 🚨 This issue needs some love. triage me I really want to be triaged.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants