fix(firestore): correct cursor flipping in limit_to_last #28137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix Google::Cloud::Firestore::Query#limit_to_last Ensure that cursors are correctly flipped when using limit_to_last in Firestore queries. This change moves the assignment of new_start_at and new_end_at outside of the conditional blocks to ensure they are always set correctly. Added tests to cover scenarios with order, start_at, and end_at in combination with limit_to_last. closes: #27527
shubhangi-google
pushed a commit
to shubhangi-google/google-cloud-ruby
that referenced
this pull request
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that cursors are correctly flipped when using limit_to_last in Firestore queries. This change moves the assignment of new_start_at and new_end_at outside of the conditional blocks to ensure they are always set correctly. Added tests to cover scenarios with order, start_at, and end_at in combination with limit_to_last.
closes: #27527