-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use []byte or custom type for pubsub Message data #49
Comments
Ideally we modify quicktype to support generating An alternative would be to look for all the |
The implementation of this will be rather complicated. I'll have to check with @grayside on how we can make this possible. This is one of the cases where using proto/protoc would be nice instead of jsonschema. Proto generation produces a
|
Here are the instances of protos with bytes:
|
Should be fixed with the above PR! :) |
Expected Behavior
Actual Behavior
Details
The choice to use a string was also made in our HTTP/REST libraries. We did not respect the ”format”: “byte”. We have an open issue around how it would have been nice to generate these types as []byte.
Option 2 might be nice do you could provide a custom mashaller for the type that auto encodes/decodes base64 values so the user of this library does not have to.
The text was updated successfully, but these errors were encountered: