-
Notifications
You must be signed in to change notification settings - Fork 451
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: fix buildRequest setUrl order (#1255)
* fix: fix buildRequest setUrl order * chore: add unit test * update * format * Update google-http-client/src/test/java/com/google/api/client/http/HttpRequestFactoryTest.java * Update google-http-client/src/test/java/com/google/api/client/http/HttpRequestFactoryTest.java Co-authored-by: Jeff Ching <chingor@google.com> Co-authored-by: Jeff Ching <chingor@google.com>
- Loading branch information
1 parent
adad01e
commit 97ffee1
Showing
2 changed files
with
44 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
41 changes: 41 additions & 0 deletions
41
google-http-client/src/test/java/com/google/api/client/http/HttpRequestFactoryTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
/* | ||
* Copyright 2021 Google LLC | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except | ||
* in compliance with the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software distributed under the License | ||
* is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express | ||
* or implied. See the License for the specific language governing permissions and limitations under | ||
* the License. | ||
*/ | ||
|
||
package com.google.api.client.http; | ||
|
||
import com.google.api.client.http.javanet.NetHttpTransport; | ||
import java.io.IOException; | ||
import junit.framework.TestCase; | ||
|
||
/** Tests {@link HttpRequestFactory}. */ | ||
public class HttpRequestFactoryTest extends TestCase { | ||
|
||
public void testBuildRequest_urlShouldBeSet() throws IllegalArgumentException, IOException { | ||
HttpRequestFactory requestFactory = | ||
new NetHttpTransport() | ||
.createRequestFactory( | ||
new HttpRequestInitializer() { | ||
@Override | ||
public void initialize(HttpRequest request) { | ||
// Url should be set by buildRequest method before calling initialize. | ||
if (request.getUrl() == null) { | ||
throw new IllegalArgumentException("url is not set in request"); | ||
} | ||
} | ||
}); | ||
GenericUrl url = new GenericUrl("https://foo.googleapis.com/"); | ||
HttpRequest request = requestFactory.buildRequest("GET", url, null); | ||
assertEquals(url, request.getUrl()); | ||
} | ||
} |