Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import order warnings #771

Closed
elharo opened this issue Aug 7, 2019 · 2 comments
Closed

Import order warnings #771

elharo opened this issue Aug 7, 2019 · 2 comments
Assignees
@meredithslota
Labels
good first issue This issue is a good place to started contributing to this repository. help wanted We'd love to have community involvement on this issue. semver: patch A minor bug fix or small change. type: cleanup An internal cleanup or hygiene concern.

Comments

@elharo
Copy link
Contributor

elharo commented Aug 7, 2019

[WARN] /tmpfs/src/github/google-http-java-client/google-http-client/src/main/java/com/google/api/client/http/apache/SSLSocketFactoryExtension.java:27: Wrong order for 'org.apache.http.conn.ssl.SSLSocketFactory' import. [ImportOrder]
[WARN] /tmpfs/src/github/google-http-java-client/google-http-client/src/main/java/com/google/api/client/http/apache/HttpExtensionMethod.java:17: Wrong order for 'org.apache.http.client.methods.HttpEntityEnclosingRequestBase' import. [ImportOrder]
[WARN] /tmpfs/src/github/google-http-java-client/google-http-client/src/main/java/com/google/api/client/http/apache/ApacheHttpResponse.java:20: Wrong order for 'org.apache.http.Header' import. [ImportOrder]
[WARN] /tmpfs/src/github/google-http-java-client/google-http-client/src/main/java/com/google/api/client/http/apache/ApacheHttpTransport.java:31: Wrong order for 'org.apache.http.HttpHost' import. [ImportOrder]
[WARN] /tmpfs/src/github/google-http-java-client/google-http-client/src/main/java/com/google/api/client/http/apache/ApacheHttpRequest.java:21: Wrong order for 'org.apache.http.HttpEntityEnclosingRequest' import. [ImportOrder]
[WARN] /tmpfs/src/github/google-http-java-client/google-http-client/src/main/java/com/google/api/client/http/apache/ContentEntity.java:22: Wrong order for 'org.apache.http.entity.AbstractHttpEntity' import. [ImportOrder]
[WARN] /tmpfs/src/github/google-http-java-client/google-http-client/src/main/java/com/google/api/client/http/OpenCensusUtils.java:31: Wrong order for 'java.util.concurrent.atomic.AtomicLong' import. [ImportOrder]
[WARN] /tmpfs/src/github/google-http-java-client/google-http-client/src/main/java/com/google/api/client/http/HttpRequest.java:31: Wrong order for 'java.io.IOException' import. [ImportOrder]
[WARN] /tmpfs/src/github/google-http-java-client/google-http-client/src/main/java/com/google/api/client/testing/http/apache/MockHttpClient.java:20: Wrong order for 'org.apache.http.ConnectionReuseStrategy' import. [ImportOrder]
@elharo elharo added good first issue This issue is a good place to started contributing to this repository. help wanted We'd love to have community involvement on this issue. semver: patch A minor bug fix or small change. type: cleanup An internal cleanup or hygiene concern. labels Aug 7, 2019
@elharo
Copy link
Contributor Author

elharo commented Aug 8, 2019

A lot of these look OK to me and IntelliJ with Google formatter doesn't change them. Possibly we need to update the Maven style rules.

@elharo elharo mentioned this issue Aug 8, 2019
Closed
@meredithslota
Copy link

Fixed by #786, I believe. Closing. Please reopen if this isn't yet fixed.

@meredithslota meredithslota self-assigned this Feb 8, 2022
clundin25 pushed a commit to clundin25/google-http-java-client that referenced this issue Aug 11, 2022
@gcf-owl-bot
build(java): Introduce Native Image testing build script changes (goo…
3971244 
…gleapis#771)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@meredithslota meredithslota

Labels
good first issue This issue is a good place to started contributing to this repository. help wanted We'd love to have community involvement on this issue. semver: patch A minor bug fix or small change. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix import order warnings googleapis/google-http-java-client
2 participants
@elharo @meredithslota