Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: adding error prone annotations to dependencyManagement #1277

Closed
wants to merge 2 commits into from

Conversation

suztomo
Copy link
Member

@suztomo suztomo commented Feb 23, 2021

"ci / dependencies" was failing in this repository due to the error prone annotation version between Guava and Truth.

Screen Shot 2021-02-23 at 11 28 33

[INFO] --- maven-enforcer-plugin:3.0.0-M3:enforce (enforce-maven) @ google-http-client ---
Warning:  Rule 2: org.apache.maven.plugins.enforcer.RequireUpperBoundDeps failed with message:
Failed while enforcing RequireUpperBoundDeps. The error(s) are [
Require upper bound dependencies error for com.google.errorprone:error_prone_annotations:2.3.4 paths to dependency are:
+-com.google.http-client:google-http-client:1.38.2-SNAPSHOT
  +-com.google.guava:guava:30.1-android
    +-com.google.errorprone:error_prone_annotations:2.3.4
and
+-com.google.http-client:google-http-client:1.38.2-SNAPSHOT
  +-com.google.guava:guava-testlib:30.1-android
    +-com.google.errorprone:error_prone_annotations:2.3.4
and
+-com.google.http-client:google-http-client:1.38.2-SNAPSHOT
  +-com.google.truth:truth:1.1.2
    +-com.google.errorprone:error_prone_annotations:2.5.1
]

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1276 ☕️

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Feb 23, 2021
@suztomo
Copy link
Member Author

suztomo commented Feb 23, 2021

"ci / dependencies" succeeded:

Screen Shot 2021-02-23 at 11 23 45

@suztomo suztomo marked this pull request as ready for review February 23, 2021 16:24
@suztomo suztomo requested a review from a team as a code owner February 23, 2021 16:24
Copy link
Contributor

@elharo elharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dupes #1268

@suztomo
Copy link
Member Author

suztomo commented Feb 23, 2021

@elharo Thank you.

@suztomo suztomo closed this Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix the "dependencies" check
2 participants