Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: unpin dependency pytest-asyncio #242

Closed
wants to merge 1 commit into from
Closed

tests: unpin dependency pytest-asyncio #242

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions noxfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ def unit(session):
)

# Install all test dependencies, then install this package in-place.
session.install("mock", "pytest", "pytest-cov", "pytest-asyncio<=0.14.0", GOOGLE_AUTH)
session.install("mock", "pytest", "pytest-cov", "pytest-asyncio", GOOGLE_AUTH)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that this is a test-only dependency, maybe we should be adding , "-c", constraints_path here, and then maybe excluding the known-bad versions in testing/constraints*.txt. Likewise for the system test session below.

session.install("-e", ".[requests,aiohttp]", "-c", constraints_path)

# Run py.test against the unit tests.
Expand Down Expand Up @@ -244,7 +244,7 @@ def system(session):

# Run py.test against the async system tests.
if session.python.startswith("3"):
session.install("pytest-asyncio<=0.14.0")
session.install("pytest-asyncio")
session.run(
"py.test", "-s", os.path.join("tests_async", "system"), *session.posargs
)
Expand Down