Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Correctly calculate starting offset for retries of ranged reads #450

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

andrewsg
Copy link
Contributor

@andrewsg andrewsg commented Aug 7, 2024

Fixes #446 🦕

cc: @shunping, @wilson1yan

@andrewsg andrewsg requested review from a team as code owners August 7, 2024 21:39
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: storage Issues related to the googleapis/google-resumable-media-python API. labels Aug 7, 2024
Copy link

@BrennaEpp BrennaEpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewsg andrewsg merged commit 34302b4 into main Aug 7, 2024
19 checks passed
@andrewsg andrewsg deleted the resume-on-retry-from-offset branch August 7, 2024 22:07
@shunping
Copy link

shunping commented Aug 9, 2024

Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the googleapis/google-resumable-media-python API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect start offset when range reads are interrupted
4 participants