Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update iam policy sample user to be consistent with other languages #3429

Merged
merged 3 commits into from
Aug 15, 2024
Merged

docs: update iam policy sample user to be consistent with other languages #3429

merged 3 commits into from
Aug 15, 2024

Conversation

PhongChuong
Copy link
Contributor

@PhongChuong PhongChuong commented Aug 15, 2024 •
edited
Loading

Update sample to use "example-analyst-group@google.com" instead of the all user identity to be consistent with IAM policy samples from other languages.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Aug 15, 2024
@PhongChuong PhongChuong marked this pull request as ready for review August 15, 2024 16:14
@PhongChuong PhongChuong added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 15, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 15, 2024
@gcf-owl-bot gcf-owl-bot bot requested review from a team as code owners August 15, 2024 16:20
@PhongChuong PhongChuong merged commit 2fc15b3 into main Aug 15, 2024
20 checks passed
@PhongChuong PhongChuong deleted the b221179810 branch August 15, 2024 17:03
@release-please release-please bot mentioned this pull request Aug 15, 2024
Merged
@diegomarquezp diegomarquezp mentioned this pull request Aug 16, 2024
Open
lqiu96 pushed a commit that referenced this pull request Aug 28, 2024
@PhongChuong @gcf-owl-bot @lqiu96
docs: update iam policy sample user to be consistent with other langu…
1875ac9 
…ages (#3429)

* docs: update iam policy sample user to be consistent with other language samples

* fix format

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
This was referenced Sep 5, 2024
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvarowolfx alvarowolfx alvarowolfx approved these changes

@shollyman shollyman shollyman approved these changes

Assignees
No one assigned
Labels
size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PhongChuong @shollyman @alvarowolfx