-
Notifications
You must be signed in to change notification settings - Fork 84
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
chore: clean up clirr-ignored-differences.xml in various proto modules
add permanent blanket exception for protobuf generated OrBuilder interface methods as we don't consider these breaking.
- Loading branch information
1 parent
58d2101
commit 523afa4
Showing
6 changed files
with
27 additions
and
242 deletions.
There are no files selected for viewing
51 changes: 0 additions & 51 deletions
51
google-cloud-bigquerystorage/clirr-ignored-differences.xml
This file was deleted.
Oops, something went wrong.
9 changes: 0 additions & 9 deletions
9
grpc-google-cloud-bigquerystorage-v1beta1/clirr-ignored-differences.xml
This file was deleted.
Oops, something went wrong.
20 changes: 20 additions & 0 deletions
20
proto-google-cloud-bigquerystorage-v1/clirr-ignored-differences.xml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <!-- see http://www.mojohaus.org/clirr-maven-plugin/examples/ignored-differences.html --> | ||
| <differences> | ||
| <!-- Allow below protobuf changes as non-breaking--> | ||
| <difference> | ||
| <differenceType>7012</differenceType> | ||
| <className>com/google/cloud/bigquery/storage/v1/*OrBuilder</className> | ||
| <method>* get*(*)</method> | ||
| </difference> | ||
| <difference> | ||
| <differenceType>7012</differenceType> | ||
| <className>com/google/cloud/bigquery/storage/v1/*OrBuilder</className> | ||
| <method>boolean contains*(*)</method> | ||
| </difference> | ||
| <difference> | ||
| <differenceType>7012</differenceType> | ||
| <className>com/google/cloud/bigquery/storage/v1/*OrBuilder</className> | ||
| <method>boolean has*(*)</method> | ||
| </difference> | ||
| </differences> |
10 changes: 0 additions & 10 deletions
10
proto-google-cloud-bigquerystorage-v1alpha2/clirr-ignored-differences.xml
This file was deleted.
Oops, something went wrong.
9 changes: 0 additions & 9 deletions
9
proto-google-cloud-bigquerystorage-v1beta1/clirr-ignored-differences.xml
This file was deleted.
Oops, something went wrong.
170 changes: 7 additions & 163 deletions
170
proto-google-cloud-bigquerystorage-v1beta2/clirr-ignored-differences.xml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,176 +1,20 @@ | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <!-- see http://www.mojohaus.org/clirr-maven-plugin/examples/ignored-differences.html --> | ||
| <differences> | ||
| <!-- TODO(stephwang): To be removed after the release --> | ||
|
|
||
| <!-- CONSTANT FIELDS REMOVED --> | ||
| <!-- Allow below protobuf changes as non-breaking--> | ||
| <difference> | ||
| <differenceType>6011</differenceType> | ||
| <className>com/google/cloud/bigquery/storage/v1beta2/AppendRowsRequest</className> | ||
| <field>IGNORE_UNKNOWN_FIELDS_FIELD_NUMBER</field> | ||
| </difference> | ||
| <difference> | ||
| <differenceType>6011</differenceType> | ||
| <className>com/google/cloud/bigquery/storage/v1beta2/AppendRowsResponse</className> | ||
| <field>OFFSET_FIELD_NUMBER</field> | ||
| </difference> | ||
| <difference> | ||
| <differenceType>6011</differenceType> | ||
| <className>com/google/cloud/bigquery/storage/v1beta2/WriteStream</className> | ||
| <field>EXTERNAL_ID_FIELD_NUMBER</field> | ||
| </difference> | ||
|
|
||
| <!-- METHODS REMOVED --> | ||
| <difference> | ||
| <differenceType>7002</differenceType> | ||
| <className>com/google/cloud/bigquery/storage/v1beta2/AppendRowsRequest</className> | ||
| <method>boolean getIgnoreUnknownFields()</method> | ||
| </difference> | ||
| <difference> | ||
| <differenceType>7002</differenceType> | ||
| <className>com/google/cloud/bigquery/storage/v1beta2/AppendRowsRequest$Builder</className> | ||
| <method>com.google.cloud.bigquery.storage.v1beta2.AppendRowsRequest$Builder clearIgnoreUnknownFields()</method> | ||
| </difference> | ||
| <difference> | ||
| <differenceType>7002</differenceType> | ||
| <className>com/google/cloud/bigquery/storage/v1beta2/AppendRowsRequest*</className> | ||
| <method>boolean getIgnoreUnknownFields()</method> | ||
| </difference> | ||
| <difference> | ||
| <className>com/google/cloud/bigquery/storage/v1beta2/AppendRowsRequest$Builder</className> | ||
| <differenceType>7002</differenceType> | ||
| <method>com.google.cloud.bigquery.storage.v1beta2.AppendRowsRequest$Builder setIgnoreUnknownFields(boolean)</method> | ||
| </difference> | ||
| <difference> | ||
| <className>com/google/cloud/bigquery/storage/v1beta2/AppendRowsRequest$Builder</className> | ||
| <differenceType>7002</differenceType> | ||
| <method>boolean getIgnoreUnknownFields()</method> | ||
| </difference> | ||
| <difference> | ||
| <className>com/google/cloud/bigquery/storage/v1beta2/AppendRowsResponse</className> | ||
| <differenceType>7002</differenceType> | ||
| <method>long getOffset()</method> | ||
| </difference> | ||
| <difference> | ||
| <className>com/google/cloud/bigquery/storage/v1beta2/AppendRowsResponse$Builder</className> | ||
| <differenceType>7002</differenceType> | ||
| <method>com.google.cloud.bigquery.storage.v1beta2.AppendRowsResponse$Builder clearOffset()</method> | ||
| </difference> | ||
| <difference> | ||
| <className>com/google/cloud/bigquery/storage/v1beta2/AppendRowsResponse$Builder</className> | ||
| <differenceType>7002</differenceType> | ||
| <method>long getOffset()</method> | ||
| </difference> | ||
| <difference> | ||
| <className>com/google/cloud/bigquery/storage/v1beta2/AppendRowsResponse$Builder</className> | ||
| <differenceType>7002</differenceType> | ||
| <method>com.google.cloud.bigquery.storage.v1beta2.AppendRowsResponse$Builder setOffset(long)</method> | ||
| </difference> | ||
| <difference> | ||
| <className>com/google/cloud/bigquery/storage/v1beta2/AppendRowsResponse$ResponseCase</className> | ||
| <differenceType>6001</differenceType> | ||
| <field>OFFSET</field> | ||
| </difference> | ||
| <difference> | ||
| <className>com/google/cloud/bigquery/storage/v1beta2/AppendRowsResponseOrBuilder</className> | ||
| <differenceType>7002</differenceType> | ||
| <method>long getOffset()</method> | ||
| </difference> | ||
| <difference> | ||
| <className>com/google/cloud/bigquery/storage/v1beta2/WriteStream</className> | ||
| <differenceType>7002</differenceType> | ||
| <method>java.lang.String getExternalId()</method> | ||
| </difference> | ||
| <difference> | ||
| <className>com/google/cloud/bigquery/storage/v1beta2/WriteStream</className> | ||
| <differenceType>7002</differenceType> | ||
| <method>com.google.protobuf.ByteString getExternalIdBytes()</method> | ||
| </difference> | ||
| <difference> | ||
| <className>com/google/cloud/bigquery/storage/v1beta2/WriteStream$Builder</className> | ||
| <differenceType>7002</differenceType> | ||
| <method>com.google.cloud.bigquery.storage.v1beta2.WriteStream$Builder clearExternalId()</method> | ||
| </difference> | ||
| <difference> | ||
| <className>com/google/cloud/bigquery/storage/v1beta2/WriteStream$Builder</className> | ||
| <differenceType>7002</differenceType> | ||
| <method>java.lang.String getExternalId()</method> | ||
| </difference> | ||
| <difference> | ||
| <className>com/google/cloud/bigquery/storage/v1beta2/WriteStream$Builder</className> | ||
| <differenceType>7002</differenceType> | ||
| <method>com.google.protobuf.ByteString getExternalIdBytes()</method> | ||
| </difference> | ||
| <difference> | ||
| <className>com/google/cloud/bigquery/storage/v1beta2/WriteStream$Builder</className> | ||
| <differenceType>7002</differenceType> | ||
| <method>com.google.cloud.bigquery.storage.v1beta2.WriteStream$Builder setExternalId(java.lang.String)</method> | ||
| </difference> | ||
| <difference> | ||
| <className>com/google/cloud/bigquery/storage/v1beta2/WriteStream$Builder</className> | ||
| <differenceType>7002</differenceType> | ||
| <method>com.google.cloud.bigquery.storage.v1beta2.WriteStream$Builder setExternalIdBytes(com.google.protobuf.ByteString)</method> | ||
| </difference> | ||
| <difference> | ||
| <className>com/google/cloud/bigquery/storage/v1beta2/WriteStreamOrBuilder</className> | ||
| <differenceType>7002</differenceType> | ||
| <method>java.lang.String getExternalId()</method> | ||
| </difference> | ||
| <difference> | ||
| <className>com/google/cloud/bigquery/storage/v1beta2/WriteStreamOrBuilder</className> | ||
| <differenceType>7002</differenceType> | ||
| <method>com.google.protobuf.ByteString getExternalIdBytes()</method> | ||
| </difference> | ||
|
|
||
| <!-- METHODS ADDED --> | ||
| <difference> | ||
| <className>com/google/cloud/bigquery/storage/v1beta2/AppendRowsRequestOrBuilder</className> | ||
| <differenceType>7012</differenceType> | ||
| <method>java.lang.String getTraceId()</method> | ||
| </difference> | ||
| <difference> | ||
| <className>com/google/cloud/bigquery/storage/v1beta2/AppendRowsRequestOrBuilder</className> | ||
| <differenceType>7012</differenceType> | ||
| <method>com.google.protobuf.ByteString getTraceIdBytes()</method> | ||
| </difference> | ||
| <difference> | ||
| <className>com/google/cloud/bigquery/storage/v1beta2/AppendRowsResponseOrBuilder</className> | ||
| <differenceType>7012</differenceType> | ||
| <method>com.google.cloud.bigquery.storage.v1beta2.AppendRowsResponse$AppendResult getAppendResult()</method> | ||
| </difference> | ||
| <difference> | ||
| <className>com/google/cloud/bigquery/storage/v1beta2/AppendRowsResponseOrBuilder</className> | ||
| <differenceType>7012</differenceType> | ||
| <method>com.google.cloud.bigquery.storage.v1beta2.AppendRowsResponse$AppendResultOrBuilder getAppendResultOrBuilder()</method> | ||
| </difference> | ||
| <difference> | ||
| <className>com/google/cloud/bigquery/storage/v1beta2/AppendRowsResponseOrBuilder</className> | ||
| <differenceType>7012</differenceType> | ||
| <method>boolean hasAppendResult()</method> | ||
| </difference> | ||
| <difference> | ||
| <className>com/google/cloud/bigquery/storage/v1beta2/BatchCommitWriteStreamsResponseOrBuilder</className> | ||
| <differenceType>7012</differenceType> | ||
| <method>com.google.cloud.bigquery.storage.v1beta2.StorageError getStreamErrors(int)</method> | ||
| </difference> | ||
| <difference> | ||
| <className>com/google/cloud/bigquery/storage/v1beta2/BatchCommitWriteStreamsResponseOrBuilder</className> | ||
| <differenceType>7012</differenceType> | ||
| <method>int getStreamErrorsCount()</method> | ||
| </difference> | ||
| <difference> | ||
| <className>com/google/cloud/bigquery/storage/v1beta2/BatchCommitWriteStreamsResponseOrBuilder</className> | ||
| <differenceType>7012</differenceType> | ||
| <method>java.util.List getStreamErrorsList()</method> | ||
| <className>com/google/cloud/bigquery/storage/v1/*OrBuilder</className> | ||
| <method>* get*(*)</method> | ||
| </difference> | ||
| <difference> | ||
| <className>com/google/cloud/bigquery/storage/v1beta2/BatchCommitWriteStreamsResponseOrBuilder</className> | ||
| <differenceType>7012</differenceType> | ||
| <method>com.google.cloud.bigquery.storage.v1beta2.StorageErrorOrBuilder getStreamErrorsOrBuilder(int)</method> | ||
| <className>com/google/cloud/bigquery/storage/v1/*OrBuilder</className> | ||
| <method>boolean contains*(*)</method> | ||
| </difference> | ||
| <difference> | ||
| <className>com/google/cloud/bigquery/storage/v1beta2/BatchCommitWriteStreamsResponseOrBuilder</className> | ||
| <differenceType>7012</differenceType> | ||
| <method>java.util.List getStreamErrorsOrBuilderList()</method> | ||
| <className>com/google/cloud/bigquery/storage/v1/*OrBuilder</className> | ||
| <method>boolean has*(*)</method> | ||
| </difference> | ||
| </differences> |