Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: call awaitTermination when close the stream writer #1111

Merged
merged 1 commit into from
Jun 5, 2021
Merged

fix: call awaitTermination when close the stream writer #1111

merged 1 commit into from
Jun 5, 2021

Conversation

yirutang
Copy link
Contributor

@yirutang yirutang commented Jun 4, 2021

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

@yirutang yirutang requested review from a team and stephaniewang526 June 4, 2021 16:52
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jun 4, 2021
@product-auto-label product-auto-label bot added the api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. label Jun 4, 2021
@reuvenlax
Copy link

LGTM

@yirutang yirutang changed the title fix:call awaitTermination when close the stream writer fix: call awaitTermination when close the stream writer Jun 4, 2021
@stephaniewang526 stephaniewang526 merged commit 0f7db50 into googleapis:master Jun 5, 2021
@release-please release-please bot mentioned this pull request Jan 4, 2022
Closed
shubhwip pushed a commit to shubhwip/java-bigquerystorage that referenced this pull request Oct 7, 2023
@renovate-bot
chore(deps): update dependency com.google.cloud:libraries-bom to v26.…
2dcdac2 
…7.0 (googleapis#1111)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephaniewang526 stephaniewang526 stephaniewang526 approved these changes

Assignees
No one assigned
Labels
api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yirutang @reuvenlax @stephaniewang526