Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(samples): add finalize call to our samples #1471

Merged
merged 11 commits into from
Jan 10, 2022
Merged

docs(samples): add finalize call to our samples #1471

merged 11 commits into from
Jan 10, 2022

Conversation

yirutang
Copy link
Contributor

@yirutang yirutang commented Jan 7, 2022

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

@product-auto-label product-auto-label bot added api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. samples Issues that are directly related to samples. labels Jan 7, 2022
@yirutang yirutang changed the title fix:Add finalize call to our samples fix: Add finalize call to our samples Jan 7, 2022
@@ -64,7 +65,9 @@ public static void writeCommittedStream(String projectId, String datasetName, St
try (JsonStreamWriter writer =
JsonStreamWriter.newBuilder(writeStream.getName(), writeStream.getTableSchema())
.build()) {
// Write two batches to the stream, each with 10 JSON records.
// Write two batches to the stream, each with 10 JSON records. A writer should be
// used for as much writes as possible. Create a writer for just one write is an
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Create > Creating

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. and added some more change to buffered stream. PTAL.

@stephaniewang526 stephaniewang526 added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 9, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 9, 2022
@stephaniewang526 stephaniewang526 self-assigned this Jan 9, 2022
@stephaniewang526 stephaniewang526 changed the title fix: Add finalize call to our samples docs(samples): Add finalize call to our samples Jan 9, 2022
@stephaniewang526 stephaniewang526 changed the title docs(samples): Add finalize call to our samples docs(samples): add finalize call to our samples Jan 9, 2022
@yirutang yirutang requested a review from a team January 9, 2022 02:23
@yirutang yirutang requested a review from a team as a code owner January 9, 2022 02:23
@yirutang yirutang requested a review from shollyman January 9, 2022 02:23
@stephaniewang526 stephaniewang526 added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 10, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 10, 2022
@stephaniewang526 stephaniewang526 added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 10, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 10, 2022
@stephaniewang526 stephaniewang526 added the automerge Merge the pull request once unit tests and other checks pass. label Jan 10, 2022
@stephaniewang526 stephaniewang526 merged commit 47e3654 into googleapis:main Jan 10, 2022
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jan 10, 2022
gcf-merge-on-green bot pushed a commit that referenced this pull request Jan 25, 2022
🤖 I have created a release *beep* *boop*
---


### [2.8.2](v2.8.1...v2.8.2) (2022-01-25)


### Bug Fixes

* **java:** add reflection configuration for native-image testing ([#1488](#1488)) ([d87fe28](d87fe28))


### Documentation

* **samples:** add finalize call to our samples ([#1471](#1471)) ([47e3654](47e3654))
* **samples:** update to v1 in doc URls ([#1489](#1489)) ([7efe427](7efe427))


### Dependencies

* exclude un-used runtime dependencies brought in by gax-grpc ([#1490](#1490)) ([3e7833e](3e7833e))
* update dependency com.google.cloud:google-cloud-bigquery to v2.6.1 ([#1473](#1473)) ([f996cdb](f996cdb))
* update dependency com.google.cloud:google-cloud-bigquery to v2.6.2 ([#1475](#1475)) ([37c1fd8](37c1fd8))
* update dependency kr.motd.maven:os-maven-plugin to v1.7.0 ([#1476](#1476)) ([e038151](e038151))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants