-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: string to correct type (INT32, INT64, FLOAT, BOOLEAN) #1588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: bigquerystorage
Issues related to the googleapis/java-bigquerystorage API.
label
Mar 26, 2022
dark0dave
changed the title
feat: string to numeric
feat: string to correct type (INT32, INT64, FLOAT, BOOLEAN)
Mar 28, 2022
yirutang
reviewed
Mar 28, 2022
...d-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1/JsonToProtoMessage.java
Outdated
Show resolved
Hide resolved
stephaniewang526
suggested changes
Mar 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a unit test for these changes?
@stephaniewang526 tests added. |
Signed-off-by: dark0dave <dark0dave@mykolab.com>
@stephaniewang526 let me know if anything else is needed. |
stephaniewang526
added
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
Mar 29, 2022
gcf-owl-bot
bot
removed
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
Mar 29, 2022
stephaniewang526
added
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
owlbot:run
Add this label to trigger the Owlbot post processor.
labels
Mar 29, 2022
gcf-owl-bot
bot
removed
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
Mar 29, 2022
yoshi-kokoro
removed
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Mar 29, 2022
stephaniewang526
approved these changes
Mar 29, 2022
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Mar 30, 2022
🤖 I have created a release *beep* *boop* --- ### [2.11.1](v2.11.0...v2.11.1) (2022-03-29) ### Bug Fixes * Numerics cast from strings ([#1588](#1588)) ([085768b](085768b)) ### Dependencies * update dependency com.google.cloud:google-cloud-bigquery to v2.10.0 ([#1578](#1578)) ([adca54e](adca54e)) * update dependency com.google.cloud:google-cloud-bigquery to v2.10.1 ([#1583](#1583)) ([cc33d0e](cc33d0e)) * update dependency com.google.cloud:google-cloud-bigquery to v2.10.2 ([#1587](#1587)) ([d4ab7f6](d4ab7f6)) * update dependency com.google.cloud:google-cloud-bigquery to v2.10.3 ([#1591](#1591)) ([0c62c85](0c62c85)) * update dependency com.google.cloud:google-cloud-bigquery to v2.10.4 ([#1594](#1594)) ([05e9062](05e9062)) * update dependency com.google.cloud:google-cloud-shared-dependencies to v2.9.0 ([#1593](#1593)) ([5234809](5234809)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
gcf-owl-bot bot
added a commit
that referenced
this pull request
Sep 26, 2022
…#1588) * chore: pin versions of dependencies for compatibility with Python 3.6 * fix path of requirements file in synthtool Source-Link: googleapis/synthtool@69cdb47 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:6566dc8226f20993af18e5a4e7a2b1ba85a292b02dedb6a1634cf10e1b418fa5
shubhwip
pushed a commit
to shubhwip/java-bigquerystorage
that referenced
this pull request
Oct 7, 2023
…googleapis#1588) (googleapis#996) * chore: pin versions of dependencies for compatibility with Python 3.6 * fix path of requirements file in synthtool Source-Link: googleapis/synthtool@69cdb47 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:6566dc8226f20993af18e5a4e7a2b1ba85a292b02dedb6a1634cf10e1b418fa5 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1586, this allows users to send strings of numerics to the api and have them case properly into the correct numeric type.