Skip to content

Commit

Permalink
test: fix dependency conflict in integration tests (#4429)
Browse files Browse the repository at this point in the history
bigtable-hbase-*-integration-tests declare a dependency on truth assertion library. truth has a transitive dependency on guava-*-android. Because of maven's dependency resolution, this dependency overrides the guava version that bigtable-hbase & java-bigtable need which is the jre version of guava. To mitigate the conflict, this change excludes truth's transitive dep on guava

Change-Id: Iea16d837f71d2b4f8f037fa870fa871dcc2fb64b
  • Loading branch information
igorbernstein2 authored Jul 16, 2024
1 parent f244ff9 commit 21ea0b6
Show file tree
Hide file tree
Showing 3 changed files with 24 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,14 @@ limitations under the License.
<artifactId>truth</artifactId>
<version>${truth.version}</version>
<scope>test</scope>
<exclusions>
<!-- truth depends on -android variant of guava, which conflicts with the guava version that
we use in the client -->
<exclusion>
<groupId>com.google.guava</groupId>
<artifactId>guava</artifactId>
</exclusion>
</exclusions>
</dependency>
</dependencies>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -522,6 +522,14 @@ limitations under the License.
<artifactId>truth</artifactId>
<version>${truth.version}</version>
<scope>test</scope>
<exclusions>
<!-- truth depends on -android variant of guava, which conflicts with the guava version that
we use in the client -->
<exclusion>
<groupId>com.google.guava</groupId>
<artifactId>guava</artifactId>
</exclusion>
</exclusions>
</dependency>
</dependencies>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -493,6 +493,14 @@ limitations under the License.
<artifactId>truth</artifactId>
<version>${truth.version}</version>
<scope>test</scope>
<exclusions>
<!-- truth depends on -android variant of guava, which conflicts with the guava version that
we use in the client -->
<exclusion>
<groupId>com.google.guava</groupId>
<artifactId>guava</artifactId>
</exclusion>
</exclusions>
</dependency>
</dependencies>

Expand Down

0 comments on commit 21ea0b6

Please sign in to comment.