Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: temporarily make clirr optional check, skip clirr on dependency check #3598

Merged
merged 1 commit into from
May 3, 2022
Merged

build: temporarily make clirr optional check, skip clirr on dependency check #3598

merged 1 commit into from
May 3, 2022

Conversation

kolea2
Copy link
Collaborator

@kolea2 kolea2 commented May 2, 2022

To unblock #3592 which needs further investigation

@kolea2 kolea2 requested a review from a team as a code owner May 2, 2022 20:38
@generated-files-bot
Copy link

Warning: This pull request is touching the following templated files:

  • .github/sync-repo-settings.yaml

@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigtable Issues related to the googleapis/java-bigtable-hbase API. labels May 2, 2022
igorbernstein2
igorbernstein2 approved these changes May 2, 2022
View reviewed changes
Copy link
Collaborator

@igorbernstein2 igorbernstein2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kolea2 kolea2 added the owlbot:run Add this label to trigger the Owlbot post processor. label May 2, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 2, 2022
@kolea2 kolea2 added automerge Merge the pull request once unit tests and other checks pass. owlbot:run Add this label to trigger the Owlbot post processor. labels May 2, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 2, 2022
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label May 2, 2022
@kolea2 kolea2 merged commit fb650d0 into googleapis:main May 3, 2022
@kolea2 kolea2 deleted the update-repo-settings branch May 3, 2022 14:03
vermas2012 pushed a commit to vermas2012/java-bigtable-hbase that referenced this pull request May 3, 2022
@kolea2 @vermas2012
build: temporarily make clirr optional check, skip clirr on dependenc…
02e69d6 
…y check (googleapis#3598)
@prash-mi prash-mi mentioned this pull request Feb 16, 2023
Merged
@kolea2 kolea2 mentioned this pull request Feb 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igorbernstein2 igorbernstein2 igorbernstein2 approved these changes

Assignees
No one assigned
Labels
api: bigtable Issues related to the googleapis/java-bigtable-hbase API. size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kolea2 @igorbernstein2