-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: set buffer size to 8MB for export jobs to reduce ram usage #4366
Conversation
No region tags are edited in this PR.This comment is generated by snippet-bot.
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot. |
Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot. |
🤖 I have created a release *beep* *boop* --- ## [2.14.3](https://github.com/googleapis/java-bigtable-hbase/compare/v2.14.2...v2.14.3) (2024-07-29) ### Bug Fixes * align the handling of regular expressions between hbase & bigtable ([#4430](https://github.com/googleapis/java-bigtable-hbase/issues/4430)) ([ae0a15d](https://github.com/googleapis/java-bigtable-hbase/commit/ae0a15d44ccf7c8b959edaac1f301927dabe09c2)) ### Performance Improvements * Set gcsUploadBufferSizeBytes to 8MB for Export Jobs to reduce RAM usage ([#4366](https://github.com/googleapis/java-bigtable-hbase/issues/4366)) ([e59d453](https://github.com/googleapis/java-bigtable-hbase/commit/e59d453006372a59fd8d2461c641fd75c007a7f5)) ### Dependencies * upgrade beam to 2.57.0 ([#4432](https://github.com/googleapis/java-bigtable-hbase/issues/4432)) ([f20b907](https://github.com/googleapis/java-bigtable-hbase/commit/f20b9072046782eacdcf1625f04a5842ef36f430)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Beam defaults to 1MB for streaming jobs to address memory usage, but doesn't for batch jobs. In addition, the {Spark,Flink}JobServerDriver do the same thing, setting it to 1MB:
apache/beam#9647
In some internal benchmarks, 8M has been shown to not incur a cost on the throughput per worker that 1M has for the export job, so we are opting to set it to 8M.
Fixes #4365 ☕️