Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing the streamingBatchSize option, since it's no longer useful. #991

Merged
merged 1 commit into from
Aug 30, 2016

Conversation

sduskis
Copy link
Contributor

@sduskis sduskis commented Aug 30, 2016

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 30, 2016
@rameshdharan
Copy link
Contributor

Code change LGTM.

What did this option used to do / why is it no longer useful?

@sduskis
Copy link
Contributor Author

sduskis commented Aug 30, 2016

This option was very useful back in the V1 days when we read many small responses, one per row. This option would allow us to configure how many requests we'd ask back from the server. For small rows, asking gRPC to queue up many responses improved performance. The bottleneck was the latency of streaming responses between the client and the proxy. These days, we get a large response with many rows, and the old bottleneck is gone. Reading n responses at a time doesn't change performance in V2, and requires more complicated code.

@sduskis sduskis merged commit d6269c8 into googleapis:master Aug 30, 2016
@sduskis sduskis deleted the cleanup_options branch August 30, 2016 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants