-
Notifications
You must be signed in to change notification settings - Fork 86
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: Retry "received rst stream" (#586)
* fix: Retry "received rst stream" * Check if exception is InternalException instead of using fromThrowable
- Loading branch information
Showing
3 changed files
with
132 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
87 changes: 87 additions & 0 deletions
87
...ava/com/google/cloud/bigtable/data/v2/stub/readrows/ReadRowsConvertExceptionCallable.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,87 @@ | ||
| /* | ||
| * Copyright 2021 Google LLC | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * https://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package com.google.cloud.bigtable.data.v2.stub.readrows; | ||
|
|
||
| import com.google.api.core.InternalApi; | ||
| import com.google.api.gax.rpc.ApiCallContext; | ||
| import com.google.api.gax.rpc.ApiException; | ||
| import com.google.api.gax.rpc.InternalException; | ||
| import com.google.api.gax.rpc.ResponseObserver; | ||
| import com.google.api.gax.rpc.ServerStreamingCallable; | ||
| import com.google.api.gax.rpc.StreamController; | ||
|
|
||
| /** | ||
| * This callable converts the "Received rst stream" exception into a retryable {@link ApiException}. | ||
| */ | ||
| @InternalApi | ||
| public final class ReadRowsConvertExceptionCallable<ReadRowsRequest, RowT> | ||
| extends ServerStreamingCallable<ReadRowsRequest, RowT> { | ||
|
|
||
| private final ServerStreamingCallable<ReadRowsRequest, RowT> innerCallable; | ||
|
|
||
| public ReadRowsConvertExceptionCallable( | ||
| ServerStreamingCallable<ReadRowsRequest, RowT> innerCallable) { | ||
| this.innerCallable = innerCallable; | ||
| } | ||
|
|
||
| @Override | ||
| public void call( | ||
| ReadRowsRequest request, ResponseObserver<RowT> responseObserver, ApiCallContext context) { | ||
| ReadRowsConvertExceptionResponseObserver<RowT> observer = | ||
| new ReadRowsConvertExceptionResponseObserver<>(responseObserver); | ||
| innerCallable.call(request, observer, context); | ||
| } | ||
|
|
||
| private class ReadRowsConvertExceptionResponseObserver<RowT> implements ResponseObserver<RowT> { | ||
|
|
||
| private final ResponseObserver<RowT> outerObserver; | ||
|
|
||
| ReadRowsConvertExceptionResponseObserver(ResponseObserver<RowT> outerObserver) { | ||
| this.outerObserver = outerObserver; | ||
| } | ||
|
|
||
| @Override | ||
| public void onStart(StreamController controller) { | ||
| outerObserver.onStart(controller); | ||
| } | ||
|
|
||
| @Override | ||
| public void onResponse(RowT response) { | ||
| outerObserver.onResponse(response); | ||
| } | ||
|
|
||
| @Override | ||
| public void onError(Throwable t) { | ||
| outerObserver.onError(convertException(t)); | ||
| } | ||
|
|
||
| @Override | ||
| public void onComplete() { | ||
| outerObserver.onComplete(); | ||
| } | ||
| } | ||
|
|
||
| private Throwable convertException(Throwable t) { | ||
| // Long lived connections sometimes are disconnected via an RST frame. This error is | ||
| // transient and should be retried. | ||
| if (t instanceof InternalException) { | ||
| if (t.getMessage() != null && t.getMessage().contains("Received Rst stream")) { | ||
| return new InternalException(t, ((InternalException) t).getStatusCode(), true); | ||
| } | ||
| } | ||
| return t; | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters