Skip to content

Commit

Permalink
fix: remove grpclb (#2033)
Browse files Browse the repository at this point in the history
* fix: remove grpclb

* fix: remove grpclb

* fix: remove grpclb

* fix: remove grpclb

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Igor Bernstein <igorbernstein@google.com>
  • Loading branch information
3 people authored and lqiu96 committed Jul 26, 2024
1 parent 2203649 commit f2889ce
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 11 deletions.
8 changes: 1 addition & 7 deletions google-cloud-bigtable/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -179,11 +179,6 @@
<groupId>io.grpc</groupId>
<artifactId>grpc-core</artifactId>
</dependency>
<dependency>
<groupId>io.grpc</groupId>
<artifactId>grpc-grpclb</artifactId>
<scope>runtime</scope>
</dependency>
<dependency>
<groupId>io.grpc</groupId>
<artifactId>grpc-googleapis</artifactId>
Expand Down Expand Up @@ -698,11 +693,10 @@
<artifactId>maven-dependency-plugin</artifactId>
<configuration>
<!--
grpc-grpclb is used at runtime using reflection
grpc-auth is not directly used transitively, but is pulled to align with other grpc parts
opencensus-impl-core is brought in transitively through opencensus-impl
-->
<usedDependencies>io.grpc:grpc-auth,io.grpc:grpc-grpclb</usedDependencies>
<usedDependencies>io.grpc:grpc-auth</usedDependencies>
<ignoredUsedUndeclaredDependencies>
<ignoredUsedUndeclaredDependency>io.opencensus:opencensus-impl-core</ignoredUsedUndeclaredDependency>
</ignoredUsedUndeclaredDependencies>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -356,10 +356,7 @@ public static InstantiatingGrpcChannelProvider.Builder defaultGrpcTransportProvi
.setMaxInboundMessageSize(MAX_MESSAGE_SIZE)
.setKeepAliveTime(Duration.ofSeconds(30)) // sends ping in this interval
.setKeepAliveTimeout(
Duration.ofSeconds(10)) // wait this long before considering the connection dead
// Attempts direct access to CBT service over gRPC to improve throughput,
// whether the attempt is allowed is totally controlled by service owner.
.setAttemptDirectPath(true);
Duration.ofSeconds(10)); // wait this long before considering the connection dead
}

@SuppressWarnings("WeakerAccess")
Expand Down

0 comments on commit f2889ce

Please sign in to comment.