Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(test): fix api breakage in DirectPath integration tests #1157

Merged
merged 1 commit into from
Feb 7, 2022

Conversation

kongweihan
Copy link
Contributor

The ComputeEngineChannelBuilder layer no longer exists and thus should be removed.

This can only be tested by running kokoro test on GCE. Local IT tests pass but can't prove that this is going to fix it in kokoro.

@kongweihan kongweihan requested a review from a team as a code owner February 4, 2022 19:33
@product-auto-label product-auto-label bot added the api: bigtable Issues related to the googleapis/java-bigtable API. label Feb 4, 2022
@igorbernstein2 igorbernstein2 added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:run Add this label to force Kokoro to re-run the tests. labels Feb 5, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 5, 2022
@igorbernstein2
Copy link
Contributor

Thanks for fixing this!
Can you fix formatting by running mvn com.coveo:fmt-maven-plugin:format

@igorbernstein2 igorbernstein2 changed the title Remove unwrap of ComputeEngineChannelBuilder chore: remove unwrap of ComputeEngineChannelBuilder Feb 7, 2022
@igorbernstein2
Copy link
Contributor

I ran this on a gce vm and can confirm that this works

Copy link
Contributor

@igorbernstein2 igorbernstein2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@igorbernstein2 igorbernstein2 changed the title chore: remove unwrap of ComputeEngineChannelBuilder chore: unwrap of ComputeEngineChannelBuilder for DirectPath tests Feb 7, 2022
@igorbernstein2 igorbernstein2 changed the title chore: unwrap of ComputeEngineChannelBuilder for DirectPath tests chore(test): fix api breakage in DirectPath integration tests Feb 7, 2022
@igorbernstein2 igorbernstein2 added automerge Merge the pull request once unit tests and other checks pass. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Feb 7, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 7, 2022
@igorbernstein2 igorbernstein2 added the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 7, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 7, 2022
@gcf-merge-on-green gcf-merge-on-green bot merged commit 5fa00c8 into googleapis:main Feb 7, 2022
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Feb 7, 2022
gcf-merge-on-green bot pushed a commit that referenced this pull request Feb 8, 2022
mutianf pushed a commit to mutianf/java-bigtable that referenced this pull request Mar 18, 2022
…apis#1157)

The ComputeEngineChannelBuilder layer no longer exists and thus should be removed.

This can only be tested by running kokoro test on GCE. Local IT tests pass but can't prove that this is going to fix it in kokoro.
mutianf pushed a commit to mutianf/java-bigtable that referenced this pull request Mar 18, 2022
mutianf pushed a commit to mutianf/java-bigtable that referenced this pull request May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the googleapis/java-bigtable API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants