-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(test): fix api breakage in DirectPath integration tests #1157
Merged
gcf-merge-on-green
merged 1 commit into
googleapis:main
from
kongweihan:kongweihan-patch-1
Feb 7, 2022
Merged
chore(test): fix api breakage in DirectPath integration tests #1157
gcf-merge-on-green
merged 1 commit into
googleapis:main
from
kongweihan:kongweihan-patch-1
Feb 7, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: bigtable
Issues related to the googleapis/java-bigtable API.
label
Feb 4, 2022
igorbernstein2
added
kokoro:run
Add this label to force Kokoro to re-run the tests.
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
and removed
kokoro:run
Add this label to force Kokoro to re-run the tests.
labels
Feb 5, 2022
yoshi-kokoro
removed
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Feb 5, 2022
Thanks for fixing this! |
igorbernstein2
changed the title
Remove unwrap of ComputeEngineChannelBuilder
chore: remove unwrap of ComputeEngineChannelBuilder
Feb 7, 2022
kongweihan
force-pushed
the
kongweihan-patch-1
branch
from
February 7, 2022 17:22
a52447c
to
a106cb9
Compare
I ran this on a gce vm and can confirm that this works |
igorbernstein2
approved these changes
Feb 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
igorbernstein2
changed the title
chore: remove unwrap of ComputeEngineChannelBuilder
chore: unwrap of ComputeEngineChannelBuilder for DirectPath tests
Feb 7, 2022
igorbernstein2
changed the title
chore: unwrap of ComputeEngineChannelBuilder for DirectPath tests
chore(test): fix api breakage in DirectPath integration tests
Feb 7, 2022
kongweihan
force-pushed
the
kongweihan-patch-1
branch
from
February 7, 2022 20:42
a106cb9
to
3174ebc
Compare
igorbernstein2
added
automerge
Merge the pull request once unit tests and other checks pass.
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
labels
Feb 7, 2022
yoshi-kokoro
removed
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Feb 7, 2022
igorbernstein2
added
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
Feb 7, 2022
gcf-owl-bot
bot
removed
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
Feb 7, 2022
gcf-merge-on-green
bot
removed
the
automerge
Merge the pull request once unit tests and other checks pass.
label
Feb 7, 2022
Merged
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Feb 8, 2022
Trigger a release of #1157
mutianf
pushed a commit
to mutianf/java-bigtable
that referenced
this pull request
Mar 18, 2022
…apis#1157) The ComputeEngineChannelBuilder layer no longer exists and thus should be removed. This can only be tested by running kokoro test on GCE. Local IT tests pass but can't prove that this is going to fix it in kokoro.
mutianf
pushed a commit
to mutianf/java-bigtable
that referenced
this pull request
Mar 18, 2022
Trigger a release of googleapis#1157
mutianf
pushed a commit
to mutianf/java-bigtable
that referenced
this pull request
May 3, 2022
Trigger a release of googleapis#1157
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ComputeEngineChannelBuilder layer no longer exists and thus should be removed.
This can only be tested by running kokoro test on GCE. Local IT tests pass but can't prove that this is going to fix it in kokoro.