Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add getServiceName() to EnhancedBigTableStubSettings #2256

Merged
merged 2 commits into from
Jun 10, 2024

Conversation

lqiu96
Copy link
Contributor

@lqiu96 lqiu96 commented Jun 10, 2024

Adds a duplicate getServiceName() implementation to EnhancedBigTableStubSettings. This is similar to

@Override
public String getServiceName() {
return "bigtable";
}
, but is re-implemented as EnhancedBigTableStubSettings does not implement BigtableStubSettings

@lqiu96 lqiu96 requested review from a team as code owners June 10, 2024 20:32
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigtable Issues related to the googleapis/java-bigtable API. labels Jun 10, 2024
@gcf-owl-bot gcf-owl-bot bot requested a review from a team as a code owner June 10, 2024 20:35
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Jun 10, 2024
@igorbernstein2 igorbernstein2 added the automerge Merge the pull request once unit tests and other checks pass. label Jun 10, 2024
@gcf-merge-on-green gcf-merge-on-green bot merged commit da703db into main Jun 10, 2024
22 of 23 checks passed
@gcf-merge-on-green gcf-merge-on-green bot deleted the add-service-name branch June 10, 2024 21:00
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the googleapis/java-bigtable API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants