Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: removing upper bounds check from required checks #1941

Merged
merged 1 commit into from
May 6, 2021
Merged

ci: removing upper bounds check from required checks #1941

merged 1 commit into from
May 6, 2021

Conversation

suztomo
Copy link
Member

@suztomo suztomo commented Apr 28, 2021 •
edited
Loading

As per #1940 (comment), I'm deleting the upper-bounds check from this repository. This is the first step of removing the upper bounds check in this repository.

Screen Shot 2021-04-28 at 16 20 17

Once the "required" mark is gone, I'll delete the files in #1942.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

@suztomo suztomo requested a review from a team as a code owner April 28, 2021 20:19
@generated-files-bot
Copy link

Warning: This pull request is touching the following templated files:

  • .github/sync-repo-settings.yaml

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Apr 28, 2021
@suztomo suztomo mentioned this pull request Apr 29, 2021
Merged
4 tasks
@suztomo
Copy link
Member Author

suztomo commented May 6, 2021

@chingor13 @stephaniewang526 Given the google-cloud-bom release process has the convergence check already (#1940 (comment)), I think it's ok to delete the "ci / bom-upper-bounds" check. What do you think?

@chingor13 chingor13 merged commit afe674b into googleapis:master May 6, 2021
@suztomo suztomo deleted the remove_upper-bounds-check-from-required branch May 6, 2021 20:16
gcf-owl-bot bot added a commit that referenced this pull request Mar 25, 2024
@gcf-owl-bot
chore: add regex to match unmanaged dependency check (#1941)
02798cc 
Source-Link: googleapis/synthtool@ca7a716
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:cecae6152a85d55c932a64515643cf2e32a1f1b6e17503080eb07744b2177f28
diegomarquezp added a commit that referenced this pull request Mar 27, 2024
@gcf-owl-bot @diegomarquezp
chore: add regex to match unmanaged dependency check (#1941) (#6499)
63f5a6e 
Source-Link: googleapis/synthtool@ca7a716
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:cecae6152a85d55c932a64515643cf2e32a1f1b6e17503080eb07744b2177f28

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Diego Marquez <diegomarquezp@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chingor13 chingor13 chingor13 approved these changes

@stephaniewang526 stephaniewang526 Awaiting requested review from stephaniewang526

@elharo elharo Awaiting requested review from elharo

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@suztomo @chingor13