Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add libraries-bom-protobuf3 #6764

Merged
merged 12 commits into from
Oct 15, 2024
Merged

feat: Add libraries-bom-protobuf3 #6764

merged 12 commits into from
Oct 15, 2024

Conversation

blakeli0
Copy link
Contributor

@blakeli0 blakeli0 commented Sep 24, 2024

This PR adds a new bom libraries-bom-protobuf3. This new bom includes identical client libraries as libraries-bom, the only difference is that libraries-bom-protobuf3 includes protobuf-java 3.x runtime version, while libraries-bom includes protobuf-java 4.x runtime version. This is a workaround in case customers run into compatibility issues with protobuf-java 4.x runtime version.

This bom will be tested with 0.1.0 version in this release cycle, once we verify that the new bom is working as we expected, we would release it with a stable version that is identical to libraries-bom. There will also be a follow up PRs that disable renovate bots for protobuf-bom, and update the automations to include the changes in release notes. See internal doc for details.

@product-auto-label product-auto-label bot added the size: l Pull request size is large. label Sep 24, 2024
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: l Pull request size is large. labels Sep 27, 2024
@blakeli0 blakeli0 marked this pull request as ready for review October 11, 2024 22:15
@blakeli0 blakeli0 requested a review from a team as a code owner October 11, 2024 22:15
libraries-bom-protobuf3/pom.xml Outdated Show resolved Hide resolved
libraries-bom-protobuf3/pom.xml Outdated Show resolved Hide resolved
@suztomo
Copy link
Member

suztomo commented Oct 12, 2024

As per the document, we don't automatically bump the protobuf version. Can you disable RenovateBot for Protobuf?

@blakeli0
Copy link
Contributor Author

As per the document, we don't automatically bump the protobuf version. Can you disable RenovateBot for Protobuf?

It will be included in follow up PRs, updated the description for this question.

Copy link
Contributor

@zhumin8 zhumin8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left few comments that can be addressed in followup prs.

Copy link
Member

@suztomo suztomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The discussion about the profiles are a minor item compared to seeing the result of testing.

@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: m Pull request size is medium. labels Oct 15, 2024
@blakeli0 blakeli0 merged commit f29e878 into main Oct 15, 2024
24 of 25 checks passed
@blakeli0 blakeli0 deleted the add-libraries-bom-protobuf3 branch October 15, 2024 15:27
@release-please release-please bot mentioned this pull request Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants