-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add libraries-bom-protobuf3 #6764
Conversation
As per the document, we don't automatically bump the protobuf version. Can you disable RenovateBot for Protobuf? |
It will be included in follow up PRs, updated the description for this question. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left few comments that can be addressed in followup prs.
Co-authored-by: Min Zhu <zhumin@google.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The discussion about the profiles are a minor item compared to seeing the result of testing.
This PR adds a new bom
libraries-bom-protobuf3
. This new bom includes identical client libraries aslibraries-bom
, the only difference is thatlibraries-bom-protobuf3
includesprotobuf-java
3.x runtime version, whilelibraries-bom
includesprotobuf-java
4.x runtime version. This is a workaround in case customers run into compatibility issues withprotobuf-java
4.x runtime version.This bom will be tested with
0.1.0
version in this release cycle, once we verify that the new bom is working as we expected, we would release it with a stable version that is identical tolibraries-bom
. There will also be a follow up PRs that disable renovate bots for protobuf-bom, and update the automations to include the changes in release notes. See internal doc for details.